Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MavenLauncher): allowing rebuilding of classpath #3270

Merged
merged 2 commits into from
Feb 24, 2020
Merged

fix(MavenLauncher): allowing rebuilding of classpath #3270

merged 2 commits into from
Feb 24, 2020

Conversation

scootafew
Copy link
Contributor

The class MavenLauncher has constructors with parameter forceRefresh, with the JavaDoc comment:

@param forceRefresh force the regeneration of classpath

However the value was actually never passed through to the SpoonPom method responsible for generating the classpath, as it was hardcoded to false. This is fixed and a method rebuildClasspath is added to MavenLauncher to enable rebuilding of the classpath without instantiating a new launcher (or directly calling the SpoonPom method). Tests for both use cases also added.

@monperrus
Copy link
Collaborator

Thanks for the PR, LGTM + see suggestion.

@nharrand
Copy link
Collaborator

LGTM! Thanks!

@nharrand nharrand merged commit 8f1aa80 into INRIA:master Feb 24, 2020
@monperrus monperrus mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monperrus monperrus monperrus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scootafew @monperrus @nharrand