fix: attach annotation to CtCatchVariable #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @nharrand you had a look at this with @gluckzhang, WDYT? |
monperrus
changed the title
|
Oops, I messed up the diff. Sorry about that. Anyway, yes LGTM too. |
|
Agree with this fix! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2934.
As far as I understand,
CtCatchgets annotated and notCtCatchVariablebecause JDT does not actually have specific nodes representing catch and represents the whole catch asArgumentof theTrynode, soSpoon creates
CtCatchfromArgument(and at that moment it gets processed and annotated) and only after that it createsCtVariableitself.Since annotations cannot be attached to
CtCatchitself, we can simply transfer them toCtCatchVariable.