Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CtPackage): add two utility methods #isEmpty() and #hasPackageInfo() #2957

Merged
merged 3 commits into from
May 15, 2019

Conversation

nharrand
Copy link
Collaborator

@nharrand nharrand commented May 3, 2019

Related to #2955

@nharrand nharrand added the review label May 6, 2019
@nharrand
Copy link
Collaborator Author

@monperrus do you merge?

@monperrus
Copy link
Collaborator

yes, I look at and merge PRs which do not have WIP in the title :-)

is that one ready?

@nharrand nharrand changed the title WiP: feat(CtPackage): add CtPackage#isEmpty() and #hasPackageInfo() feat(CtPackage): add CtPackage#isEmpty() and #hasPackageInfo() May 15, 2019
@nharrand
Copy link
Collaborator Author

yes, I look at and merge PRs which do not have WIP in the title :-)

Indeed that make sense :-D

is that one ready?

Yes.

@monperrus monperrus changed the title feat(CtPackage): add CtPackage#isEmpty() and #hasPackageInfo() feat(CtPackage): add two utility methods #isEmpty() and #hasPackageInfo() May 15, 2019
@monperrus monperrus merged commit 5b34164 into INRIA:master May 15, 2019
@monperrus
Copy link
Collaborator

Thanks a lot!

@monperrus monperrus mentioned this pull request Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants