refactor(TypeFactory#get(String qualifiedName)): Look for type in factory.Package() first, and not at the end. Workaround for #1889 #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory.Package() first, and not at the end. Workaround for #1889
|
Heavily used method yet all tests pass. OK for me. |
| @@ -419,6 +419,21 @@ public CtTypeParameterReference createReference(CtTypeParameter type) { | |||
| */ | |||
| @SuppressWarnings("unchecked") | |||
| public <T> CtType<T> get(final String qualifiedName) { | |||
| int packageIndex = qualifiedName.lastIndexOf(CtPackage.PACKAGE_SEPARATOR); | |||
| CtPackage pack; | |||
| if (packageIndex > 0) { | |||
There was a problem hiding this comment.
if (packageIndex >= 0) would be better
I am wrong here. Your code is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the name of the PR, this would refactor
TypeFactory.get(String qualifiedName). Instead of looking in existing packages for the wanted type only if it is not resolve otherwise, it starts by that.It prevent to resolve recursively nested type from their root type as a first option. If you look for
A$B$Cit won't resolveAthenA$Band thenA$B$C. ifA$Bis already reachable, it will stop there.This allow the resolution of class whose name contains
$. The current behavior can't resolve a class namedA$Bif it's not a classBnested inA.