Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I found out that filename from
SourcePosition
is lost during serialization (it's null). Although line number, column, etc. are present in deserialized model.This happens because
getFile()
usescompilationUnit
, which is null in deserialized model.I fixed that by introducing field '
file
' inSourcePosition
.Also, I provided some tests. Particularly, without this fix the following assertions fail:
Really want this fix, because without it we can't get any filename from SourcePosition from deserialized model.