fix EqualsChecker for assignments #1845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I have found a bug, in
EqualsChecker
class, and this PR is a possible fix.The problem is that
.equals
method called onCtAssignment
andCtOperatorAssignment
(which extendsCtAssignment
) returns true, once rhs and lhs statements are the same. But this is not correct.For example, statements
x = 42
andx += 42
are not the same thing at all.To fix that, I implemented
visitCtAssignment
method.Also, I provided some tests (second assert fails, without this fix).