Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some small bugs #1838

Merged
merged 1 commit into from
Feb 7, 2018
Merged

fix some small bugs #1838

merged 1 commit into from
Feb 7, 2018

Conversation

Egor18
Copy link
Contributor

@Egor18 Egor18 commented Feb 6, 2018

Hi! I was working on static analysis tool prototype, and it probably found few nasty misprints in spoon.
So, I fixed them.

@pvojtechovsky
Copy link
Collaborator

Hi! These fixes looks correct for me. Many thanks!

Could you add simple test cases, which failed before your fix? But if you have no failing test case, then no problem. I can merge it as it is ;-)

Test cases would be helpful for future to avoid similar problems. Note: Spoon code is quite complex and without good test cases it cannot evolve well.

@Egor18
Copy link
Contributor Author

Egor18 commented Feb 7, 2018

Sorry, I can't provide actual failing tests, since I'm not so familliar with this particular code.
But still, these are definately misprints.

@pvojtechovsky pvojtechovsky merged commit dbf78a9 into INRIA:master Feb 7, 2018
@Egor18 Egor18 deleted the fix_warnings branch February 15, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants