Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Spoon Filter implements java.util.function.Predicate #1798

Merged
merged 1 commit into from
Jan 1, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

No description provided.

@monperrus monperrus merged commit 2e60d6b into INRIA:master Jan 1, 2018
@monperrus
Copy link
Collaborator

Java 8 forever!

@pvojtechovsky pvojtechovsky deleted the feaFilterExPredicate branch January 1, 2018 16:49
@monperrus
Copy link
Collaborator

This breaks more code than expected: all client-side implementations of Filter, which are common, are broken.
See https://ci.inria.fr/sos/ (NpeFix and Cocospoon)

I suggest to undo this change and rather have AbstractFilter implementing Predicate.

WDYT?

@pvojtechovsky
Copy link
Collaborator Author

ok, I have no problem with undo. Please do it if you have some tool for that. Otherwise we can make new PR for that...

Could you show me short and fast example of the problem? Do they implement method test? or Not using java 8??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants