feature: Factory#createQuery(Iterable) #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detected changes by Revapi: 1. Old API: fr.inria.gforge.spoon:spoon-core:jar:6.1.0-20171205.234706-32 New API: fr.inria.gforge.spoon:spoon-core:jar:6.1.0-SNAPSHOT
|
monperrus
reviewed
Dec 6, 2017
| @@ -865,16 +872,16 @@ public void testEmptyQuery() throws Exception { | |||
|
|
|||
| //contract: empty query returns no element | |||
| assertEquals(0, launcher.getFactory().createQuery().list().size()); | |||
| assertEquals(0, launcher.getFactory().createQuery(null).list().size()); | |||
| assertEquals(0, launcher.getFactory().createQuery((Object) null).list().size()); | |||
There was a problem hiding this comment.
Adding a cast to null is not elegant IMHO. One alternative solution would be to replace createQuery(null) by createQuery()
There was a problem hiding this comment.
createQuery() is already used on the line 867, the purpose of this test is to check handling of null values. I guess that cast is OK for the test. Or optionally I can use new API and call createQuery(Arrays.asList(null)). WDYT?
|
you're right. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibility to create query on Collection of elements. No need to create helper array, just to convert collection to format acceptable by API.