review refactor: Add a new way to build a query in QueryFactory #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
changed the title
monperrus
reviewed
Nov 22, 2017
| @@ -48,4 +48,12 @@ public CtQuery createQuery() { | |||
| public CtQuery createQuery(Object input) { | |||
| return new CtQueryImpl(input); | |||
| } | |||
|
|
|||
| /** | |||
| * Creates a bound query with an optional number of inputs | |||
There was a problem hiding this comment.
what is the meaning of inputs?
not fan of pointing to an implementation in an interface.
|
interesting. it seems we need a test case. |
|
Detected changes by Revapi: 1. Old API: fr.inria.gforge.spoon:spoon-core:jar:7.0.0-20171122.113807-9 New API: fr.inria.gforge.spoon:spoon-core:jar:7.0.0-SNAPSHOT
|
|
@monperrus @pvojtechovsky if you're ok with this one, it's ready for merging. |
|
ok for me. @pvojtechovsky do you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.