Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review refactor: Remove replace methods which were using CtElement#replace #1704

Merged
merged 2 commits into from
Nov 10, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Nov 9, 2017

Fix #1385

@surli surli changed the title WiP refactor: Remove replace method which where using CtElement#replace WiP refactor: Remove replace methods which were using CtElement#replace Nov 9, 2017
@spoon-bot
Copy link
Collaborator

Detected changes by Revapi: 9.

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20171108.100023-153

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Name Change 1
Old method CtBlock::replace(CtBlock)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking
Name Change 2
Old method CtExpression::replace(CtExpression)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking
Name Change 3
Old method CtStatement::replace(CtStatement)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking
Name Change 4
Old method CtField::replace(CtField)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking
Name Change 5
Old method CtMethod::replace(CtMethod)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking
Name Change 6
Old method CtExecutableReference::replace(CtExecutableReference)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking
Name Change 7
Old method CtPackageReference::replace(CtPackageReference)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking
Name Change 8
Old method CtTypeReference::replace(CtTypeReference)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking
Name Change 9
Old method CtVariableReference::replace(CtVariableReference)
New none
Code java.method.removed
Description Method was removed.
Breaking binary: breaking

@INRIA INRIA deleted a comment from spoon-bot Nov 9, 2017
@surli surli changed the title WiP refactor: Remove replace methods which were using CtElement#replace review refactor: Remove replace methods which were using CtElement#replace Nov 9, 2017
@monperrus
Copy link
Collaborator

OK for me. I don't think it will break any code.

@monperrus monperrus merged commit c49aa9f into INRIA:master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants