Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revapi now deletes its own comments before commenting #1683

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Oct 31, 2017

Fix #1426

@monperrus
Copy link
Collaborator

What about something slightly more powerful?

#spoon-bot posts only if the computed API changes are different from the last post.
last_post = None
for comment in pr.get_comments():
  if comment.user == gh.get_user():
                last_post = comment
if comment.text != file_content:
  comment.delete()
  pr.create_issue_comment(file_content)

@surli
Copy link
Collaborator Author

surli commented Nov 6, 2017

I prefer the idea which consist in always deleting older comments from revapi, as it will also avoid duplicate message with a different order in changes and it ensures that we always have the very last report message from revapi.

@monperrus monperrus merged commit 16833da into INRIA:master Nov 7, 2017
@monperrus
Copy link
Collaborator

ok, let's try this and see how it feels. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants