review: Fix: bug related with TypeReference generics in noclasspath #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
commented
Oct 16, 2017
| return this.jdtTreeBuilder.getFactory().Type().createReference(CharOperation.toString(ref.getParameterizedTypeName())); | ||
| CtTypeReference result = this.jdtTreeBuilder.getFactory().Type().createReference(res.getQualifiedName()); | ||
| result.setActualTypeArguments(res.getActualTypeArguments()); | ||
| return result; |
There was a problem hiding this comment.
Your patch is invalid, it brokes my test (and my test is good)
There was a problem hiding this comment.
the bug is in getQualifiedName of jdt in my testcase
There was a problem hiding this comment.
Your patch is invalid, it brokes my test (and my test is good)
Yeah, I saw that. Still working on it, I come back to you when tests are passing, I was a bit too confident on the first trial ;)
surli
changed the title
monperrus
reviewed
Oct 17, 2017
|
|
||
| @Test | ||
| public void testTypeReferenceWithGenerics() throws Exception { | ||
| final Launcher launcher = new Launcher(); |
monperrus
reviewed
Oct 17, 2017
|
|
||
| @Test | ||
| public void testImportWithGenerics() throws IOException { | ||
| final Launcher launcher = new Launcher(); |
|
Ready to merge @monperrus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.