get rid of snapshotLength and hasNewContent #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder that conditions detecting whether |
|
I was myself quite surprised that it works out-of-the-box! |
| scan(target); | ||
| if (printer.getPrinterHelper().hasNewContent()) { | ||
| // the implicit drives the separator | ||
| if (!target.isImplicit()) { | ||
| printer.writeSeparator("."); |
There was a problem hiding this comment.
move scan call above into this if block?
Then it is clear when it produces output.
|
And please uncomment the last line of token writer printer test. It should pass now. |
| scan(invocation.getTarget()); | ||
| if (printer.getPrinterHelper().hasNewContent()) { | ||
| if (invocation.getTarget() != null && !invocation.getTarget().isImplicit()) { | ||
| printer.writeSeparator("."); |
There was a problem hiding this comment.
What about this call of scan?
|
It is OK for me. Let me know if you are finished. I will merge it then. |
|
I'm done, you can merge, thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1567