refactor: DefaultJavaPrettyPrinter better uses OperatorHelper

[pvojtechovsky]

• DefaultJavaPrettyPrinter uses OperatorHelper instead of now deprecated PrinterHelper methods
• Some code of DefaultJavaPrettyPrinter is more friendly to future PrinterTokenWriter review: feat: TokenWriter - support for custom pretty printed formatting #1494

[monperrus]

RevApi detects that the move of ListHelper is not finsihed, one needs to make public ListPrinter createListPrinter package-protected. Let's do it here?

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20170921.182338-36

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	method spoon.reflect.visitor.ListPrinter spoon.reflect.visitor.PrinterHelper::createListPrinter(java.lang.String, java.lang.String, java.lang.String)
New	method spoon.reflect.visitor.ListPrinter spoon.reflect.visitor.PrinterHelper::createListPrinter(java.lang.String, java.lang.String, java.lang.String)
Code	java.method.visibilityReduced
Description	visibility reduced
Breaking	binary: breaking

[monperrus]

if a method is not the API we can remove it without depreciation, so we can remove the ones in PrinterHelper.

[monperrus]

here we clearly see the configuration that will be made possible with the indirection level of OperatorHelper.

I'm OK with it.

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20170921.182338-36

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 6.

Change 1

Name	Element
Old	method spoon.reflect.visitor.ListPrinter spoon.reflect.visitor.PrinterHelper::createListPrinter(java.lang.String, java.lang.String, java.lang.String)
New	method spoon.reflect.visitor.ListPrinter spoon.reflect.visitor.PrinterHelper::createListPrinter(java.lang.String, java.lang.String, java.lang.String)
Code	java.method.visibilityReduced
Description	visibility reduced
Breaking	binary: breaking,

Change 2

Name	Element
Old	method void spoon.reflect.visitor.PrinterHelper::postWriteUnaryOperator(spoon.reflect.code.UnaryOperatorKind)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking,

Change 3

Name	Element
Old	method void spoon.reflect.visitor.PrinterHelper::preWriteUnaryOperator(spoon.reflect.code.UnaryOperatorKind)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking,

Change 4

Name	Element
Old	method void spoon.reflect.visitor.PrinterHelper::writeCharLiteral(java.lang.Character, boolean)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking,

Change 5

Name	Element
Old	method spoon.reflect.visitor.PrinterHelper spoon.reflect.visitor.PrinterHelper::writeOperator(spoon.reflect.code.BinaryOperatorKind)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking,

Change 6

Name	Element
Old	method void spoon.reflect.visitor.PrinterHelper::writeStringLiteral(java.lang.String, boolean)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking,