Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: refactor: Launcher#buildModel return a CtModel #1549

Merged
merged 7 commits into from
Sep 21, 2017
Merged

review: refactor: Launcher#buildModel return a CtModel #1549

merged 7 commits into from
Sep 21, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Sep 20, 2017

Fix #1542

@monperrus
Copy link
Collaborator

add a test?

@INRIA INRIA deleted a comment from spoon-bot Sep 20, 2017
@spoon-bot
Copy link
Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20170921.152428-33

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 1.

Change 1

Name Element
Old method void spoon.Launcher::buildModel()
New method spoon.reflect.CtModel spoon.Launcher::buildModel()
Code java.method.returnTypeChanged
Description The return type changed from 'void' to 'spoon.reflect.CtModel'.
Breaking binary: breaking,

@INRIA INRIA deleted a comment from spoon-bot Sep 21, 2017
@INRIA INRIA deleted a comment from spoon-bot Sep 21, 2017
@INRIA INRIA deleted a comment from spoon-bot Sep 21, 2017
@surli surli changed the title refactor: Launcher#buildModel return a CtModel review: refactor: Launcher#buildModel return a CtModel Sep 21, 2017
@monperrus monperrus merged commit 479573f into INRIA:master Sep 21, 2017
@surli surli mentioned this pull request Nov 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surli @monperrus @spoon-bot