review: fix: prevent renaming CtRootPackage #1523
Conversation
|
This bug occured because |
I agree, that call of setSimpleName on root package should fail with exception. May be root package might silently ignore call of setSimpleName(null) and setSimpleName("") |
|
May be root package might silently ignore call of setSimpleName(null) and setSimpleName("")
I like this idea, from the viewpoint of client code, this would be better (no additional check to write)
|
surli
changed the title
| */ | ||
| public class ElementProcessor extends AbstractProcessor<CtElement> { | ||
| public void process(CtElement element) { | ||
| if(element instanceof CtPackage && element != getFactory().Package().getRootPackage()){ |
There was a problem hiding this comment.
there is a confusion, the goal is that client code indeed never has to write this.
so the implementation RootPackage.setSimpleName would simply be ... empty.
do you see what I mean?
There was a problem hiding this comment.
do you see what I mean?
Yes, I just kept going on my initial idea. I'll change that.
Fix #1522