review: Remove deprecated from Spoon 5.9.0

[surli]

• NameFilter is moved to spoon.legacy: NamedElementFilter is preferred
• get/set encoding of SpoonModelBuilder no longer exists: the method of Environment should be used instead
• getPackageDeclaration() is removed from PrettyPrinter interface and DefaultJavaPrettyPrinter
• reset() is removed from PrettyPrinter interface but kept as private in DefaultJavaPrettyPrinter

[monperrus]

Following the guidelines of XWiki for maximum backward compatibility, instead of removing NameFilter, I propose to move it in a package spoon.legacy, so that impacted client code only has to modify the import statements.

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20170910.224504-8

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 7.

Change 1

Name	Element
Old	class spoon.reflect.visitor.filter.NameFilter
New	none
Code	java.class.removed
Description	Class was removed.
Breaking	binary: breaking

Change 2

Name	Element
Old	field spoon.support.compiler.jdt.JDTBasedSpoonCompiler.encoding
New	none
Code	java.field.removed
Description	Field removed from class.
Breaking	binary: breaking

Change 3

Name	Element
Old	method void spoon.support.compiler.jdt.FileCompilerConfig::(spoon.compiler.SpoonFolder)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

Change 4

Name	Element
Old	method java.lang.String spoon.SpoonModelBuilder::getEncoding()
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

Change 5

Name	Element
Old	method java.lang.String spoon.reflect.visitor.DefaultJavaPrettyPrinter::getPackageDeclaration()
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

Change 6

Name	Element
Old	method void spoon.reflect.visitor.DefaultJavaPrettyPrinter::reset()
New	method void spoon.reflect.visitor.DefaultJavaPrettyPrinter::reset()
Code	java.method.visibilityReduced
Description	visibility reduced
Breaking	binary: breaking

Change 7

Name	Element
Old	method void spoon.SpoonModelBuilder::setEncoding(java.lang.String)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

[surli]

I propose to move it in a package spoon.legacy

Done, despite what revapi is saying...

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-20170911.190412-10

New API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0-SNAPSHOT

Detected changes: 7.

Change 1

Name	Element
Old	class spoon.reflect.visitor.filter.NameFilter
New	none
Code	java.class.removed
Description	Class was removed.
Breaking	binary: breaking

Change 2

Name	Element
Old	field spoon.support.compiler.jdt.JDTBasedSpoonCompiler.encoding
New	none
Code	java.field.removed
Description	Field removed from class.
Breaking	binary: breaking

Change 3

Name	Element
Old	method void spoon.support.compiler.jdt.FileCompilerConfig::(spoon.compiler.SpoonFolder)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

Change 4

Name	Element
Old	method java.lang.String spoon.SpoonModelBuilder::getEncoding()
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

Change 5

Name	Element
Old	method java.lang.String spoon.reflect.visitor.DefaultJavaPrettyPrinter::getPackageDeclaration()
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

Change 6

Name	Element
Old	method void spoon.reflect.visitor.DefaultJavaPrettyPrinter::reset()
New	method void spoon.reflect.visitor.DefaultJavaPrettyPrinter::reset()
Code	java.method.visibilityReduced
Description	visibility reduced
Breaking	binary: breaking

Change 7

Name	Element
Old	method void spoon.SpoonModelBuilder::setEncoding(java.lang.String)
New	none
Code	java.method.removed
Description	Method was removed.
Breaking	binary: breaking

[monperrus]

thanks @surli