Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to org.eclipse.jdt:org.eclipse.jdt.core:3.12.3 #1492

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

This JDT is newer and has published sources in maven repository, so it is easier to debug...

@pvojtechovsky
Copy link
Collaborator Author

looks like it is compiled with JDK 1.8 :-( so not for Spoon ... yet ...

@surli
Copy link
Collaborator

surli commented Sep 12, 2017

We can ignore the status of the non-working CI check for this one.
However I wonder if we could upgrade to the org.eclipse.jdt:org.eclipse.jdt.core:3.12.3 released in march or to org.eclipse.tycho:org.eclipse.jdt.core:jar:3.13.0 released in june?
See https://mvnrepository.com/artifact/org.eclipse.jdt/org.eclipse.jdt.core vs https://mvnrepository.com/artifact/org.eclipse.tycho/org.eclipse.jdt.core

@monperrus
Copy link
Collaborator

monperrus commented Sep 12, 2017 via email

@pvojtechovsky
Copy link
Collaborator Author

I personally agree with everything what has accessible sources, so it is easier to debug problems or to understand how it works. So newer is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants