fix: ignore null items in ReplacementVisitor #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code seems ok but could you create a unit test to cover it? |
|
Looks like most uncovered stuff does not comes from |
pvojtechovsky
force-pushed
the
fixNullInReplacementVisitor
branch
from
7577366 to
2a2c700
Compare
pvojtechovsky
force-pushed
the
fixNullInReplacementVisitor
branch
from
2a2c700 to
47cf6cd
Compare
|
I am done with tests. It is ready for merge from my point of view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReplacementVisitor would fail if template parameter is null or an item of to be replaced collection is null.