Review fix(role): fix wrong roles

[tdurieux]

fix #1386

• CtCaseImpl#caseExpression -> CtRole.EXPRESSION
• CtTypeImpl#typeMembers -> CtRole.FIELD, CtRole.EXECUTABLE, CtRole.NESTED_TYPE
• CtContinueImpl#labelledStatement -> remove (DONE review: refactor(label): remove labelledStatement that was not used #1398)
• CtNewClassImpl#anonymousClass -> CtRole.EXPRESSION??

[tdurieux]

@monperrus @pvojtechovsky What is the best role for CtNewClassImpl#anonymousClass?

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-20170622.224606-57

New API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	method spoon.reflect.path.CtRole spoon.reflect.annotations.MetamodelPropertyField::role()
New	method spoon.reflect.path.CtRole[] spoon.reflect.annotations.MetamodelPropertyField::role()
Code	java.method.returnTypeChanged
Description	The return type changed from 'spoon.reflect.path.CtRole' to 'spoon.reflect.path.CtRole[]'.
Breaking	binary: breaking

[monperrus]

What is the best role for CtNewClassImpl#anonymousClass?

What about CtRole.NESTED_TYPE?

[tdurieux]

Done for me

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-20170623.121440-58

New API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	method spoon.reflect.path.CtRole spoon.reflect.annotations.MetamodelPropertyField::role()
New	method spoon.reflect.path.CtRole[] spoon.reflect.annotations.MetamodelPropertyField::role()
Code	java.method.returnTypeChanged
Description	The return type changed from 'spoon.reflect.path.CtRole' to 'spoon.reflect.path.CtRole[]'.
Breaking	binary: breaking