feature: add first metamodel support #1378
Conversation
monperrus
force-pushed
the
feat-metamodel
branch
3 times, most recently
from
6323bbc to
51ea825
Compare
|
It is on good way! May be I will have Xmas sooner? ;-) Some ideas: May be it might return Set instead of Collection. The returned references have assigned different Factory instance, may be we should add new type of spoon object under Factory, called Or return Set with qualified names of interfaces? It is faster to search in it. |
| result.add(factory.Type().get(spoon.reflect.reference.CtTypeReference.class)); | ||
| result.add(factory.Type().get(spoon.reflect.reference.CtUnboundVariableReference.class)); | ||
| result.add(factory.Type().get(spoon.reflect.reference.CtVariableReference.class)); | ||
| result.add(factory.Type().get(spoon.reflect.reference.CtWildcardReference.class)); |
There was a problem hiding this comment.
Why do you do this by hand instead of retrieving all classes of interesting packages by reflection?
There was a problem hiding this comment.
Do you know the performance of reflection?
Agree, done.
Yes, but the
Let's start with a stateless design first (stateless is better), we'll modify it later if needed.
I would prefer domain-specific types over strings |
first step for #1183
WDYT?