-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review feat(model): annotes getter and setter with a CtRole #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurieux
force-pushed
the
model_getter_setter
branch
from
June 8, 2017 09:12
4a24766
to
37ffe1c
Compare
tdurieux
changed the title
WIP feat(model): annotes getter and setter with a CtRole
review feat(model): annotes getter and setter with a CtRole
Jun 8, 2017
tdurieux
force-pushed
the
model_getter_setter
branch
from
June 8, 2017 09:20
37ffe1c
to
39b0a9d
Compare
per our discussion
|
63 tasks
… UnsettableProperty after)
monperrus
force-pushed
the
model_getter_setter
branch
from
June 8, 2017 20:28
fb1af05
to
9919c91
Compare
surli
reviewed
Jun 9, 2017
DEFAULT_EXPRESSION, | ||
THEN, | ||
ELSE, | ||
PACKAGE, | ||
SUB_PACKAGE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keeping PACKAGE
here, it seems clearer?
because it is more explicit, the role is to be a subpackage of another one |
Ok I saw the usage after asking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #1368
TODO tests