review: fix: replace wrong CtTypeInformation by CtType

[pvojtechovsky]

After simplifications of SubInheritanceHierarchyResolver (remove of #returnTypeReferences(boolean) method) there remained CtConsumer<CtTypeInformation>, but there should be CtConsumer<CtType>

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170519.225434-112

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 2.

Change 1

Name	Element
Old	method void spoon.support.visitor.SubInheritanceHierarchyResolver::forEachSubTypeInPackage(spoon.reflect.visitor.chain.CtConsumer)
New	method <T extends spoon.reflect.declaration.CtType<?>> void spoon.support.visitor.SubInheritanceHierarchyResolver::forEachSubTypeInPackage(spoon.reflect.visitor.chain.CtConsumer)
Code	java.generics.formalTypeParameterChanged
Description	The formal type parameter changed from 'T extends spoon.reflect.declaration.CtTypeInformation' to 'T extends spoon.reflect.declaration.CtType<?>'.
Breaking	source: breaking,

Change 2

Name	Element
Old	parameter void spoon.support.visitor.SubInheritanceHierarchyResolver::forEachSubTypeInPackage(===spoon.reflect.visitor.chain.CtConsumer===)
New	parameter <T extends spoon.reflect.declaration.CtType<?>> void spoon.support.visitor.SubInheritanceHierarchyResolver::forEachSubTypeInPackage(===spoon.reflect.visitor.chain.CtConsumer===)
Code	java.method.parameterTypeParameterChanged
Description	The type parameter of method parameter changed. The original type was 'spoon.reflect.visitor.chain.CtConsumer'while the new type is 'spoon.reflect.visitor.chain.CtConsumer<T extends spoon.reflect.declaration.CtType<?>>'.
Breaking	source: potentially_breaking,

[monperrus]

why do you say "remove useless generic parameter", it seems to be still there?

[pvojtechovsky]

Because first I tried to remove it, but it failed with compilation errors on CtConsumer<CtType<?>> so I had to keep generic parameter ... but with correct bound.