Add 'getBinaryFiles' to CompilationUnit. Fixes #1230.

[msteinbeck]

This is a proposal to fix #1230. I decided to use File#listFiles to detect all available .class files instead of traversing all sub types one after another in order to return existing files only. Did I miss something (except of tests which I will add if you think this method is worth adding to Spoon).

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170317.184213-5

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	none
New	method java.util.List<java.io.File> spoon.reflect.cu.CompilationUnit::getBinaryFiles()
Code	java.method.addedToInterface
Description	Method was added to an interface.
Breaking	source: breaking, semantic: potentially_breaking, binary: non_breaking

[monperrus]

Thanks for this PR.

What about returning List<SpoonFile> instead of List<File>?

Could you add a test case?

[msteinbeck]

Since getFile() returns a File as well, I would stick with File rather than SpoonFile to keep consistency.

[monperrus]

You're right. OK for File

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170320.234522-9

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	none
New	method java.util.List<java.io.File> spoon.reflect.cu.CompilationUnit::getBinaryFiles()
Code	java.method.addedToInterface
Description	Method was added to an interface.
Breaking	semantic: potentially_breaking, source: breaking, binary: non_breaking

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170320.234522-9

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	none
New	method java.util.List<java.io.File> spoon.reflect.cu.CompilationUnit::getBinaryFiles()
Code	java.method.addedToInterface
Description	Method was added to an interface.
Breaking	semantic: potentially_breaking, binary: non_breaking, source: breaking

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170320.234522-9

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	none
New	method java.util.List<java.io.File> spoon.reflect.cu.CompilationUnit::getBinaryFiles()
Code	java.method.addedToInterface
Description	Method was added to an interface.
Breaking	binary: non_breaking, semantic: potentially_breaking, source: breaking

[msteinbeck]

I think I'm done here. Feel free to merge.