review 1: feature: CtTypeParameter#getTypeDeclarer()

[pvojtechovsky]

During work with CtTypeParameter I always needed to know where this parameter is declared. I suggest to introduce this new API method into CtTypeParameter.

	/**
	 * @return the {@link CtFormalTypeDeclarer}, which declares this {@link CtTypeParameter}
	 */
	@DerivedProperty
	CtFormalTypeDeclarer getTypeDeclarer();

This PR fixes bug in TypeFactory#createReference(CtTypeParameter), which created reference without parent, so there was lost information about type parameter declarer. CtTypeParameterReference without declarer is useless.

[monperrus]

This method is good.

Two questions before merge:

• rename as getTypeParameterDeclarer?
• could you add one test?

Thanks.

[pvojtechovsky]

Rename done:
2 tests added

• one for getTypeParameterDeclarer
• second for CtTypeParameter.getReference().getDeclaration(), which did not worked before and is fixed by this PR too.

I am done. Please review

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.6.0-20170313.234505-78

New API: fr.inria.gforge.spoon:spoon-core:jar:5.6.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	none
New	method spoon.reflect.declaration.CtFormalTypeDeclarer spoon.reflect.declaration.CtTypeParameter::getTypeParameterDeclarer()
Code	java.method.addedToInterface
Description	Method was added to an interface.
Breaking	source: breaking, binary: non_breaking, semantic: potentially_breaking

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.6.0-20170313.234505-78

New API: fr.inria.gforge.spoon:spoon-core:jar:5.6.0-SNAPSHOT

Detected changes: 1.

Change 1

Name	Element
Old	none
New	method spoon.reflect.declaration.CtFormalTypeDeclarer spoon.reflect.declaration.CtTypeParameter::getTypeParameterDeclarer()
Code	java.method.addedToInterface
Description	Method was added to an interface.
Breaking	binary: non_breaking, source: breaking, semantic: potentially_breaking

[monperrus]

thanks