Fix NPE when Spoon launch with a wrong path for input resource #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith an or instead of an and. Now the test is failing, proof that the assertion is checked :)
… a local variable in the same block or by a field (or a variable in another block). First detection implemented but patch not satisfying.
Solve in using version of inria/master
msteinbeck
reviewed
Dec 20, 2016
| @Test | ||
| public void testLauncherWithWrongPathAsInput() { | ||
| expectedEx.expect(SpoonException.class); | ||
| expectedEx.expectMessage("java.io.FileNotFoundException: The following file does not exist: /Users/urli/Github/spoon/src/wrong/direction/File.java"); |
There was a problem hiding this comment.
Should a test case really depend on the message of an exception?
There was a problem hiding this comment.
Oh. Indeed I was a bit fast in my cut & paste. The intent was only to paste the FileNotFound. I fix that.
There was a problem hiding this comment.
Furthermore, I'm pretty sure that most of us do not clone Spoon into: /Users/urli/Github/spoon :)
surli
commented
Dec 20, 2016
| @Test | ||
| public void testLauncherWithWrongPathAsInput() { | ||
| expectedEx.expect(SpoonException.class); | ||
| expectedEx.expectMessage("java.io.FileNotFoundException"); |
There was a problem hiding this comment.
Change to use a try catch and make the assert in catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1042 and now encapsulate a FileNotFoundException inside a SpoonException in case of a wrong path given to Spoon.