Fix some issues with static imports and inner classes or enums #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith an or instead of an and. Now the test is failing, proof that the assertion is checked :)
… a local variable in the same block or by a field (or a variable in another block). First detection implemented but patch not satisfying.
Solve in using version of inria/master
…e tests in DefaultJavaPrettyPrinterTest)
monperrus
reviewed
Dec 16, 2016
| } | ||
|
|
||
| } | ||
| printer.writeln().writeTabs(); | ||
| } | ||
| } | ||
|
|
||
| private String removeInnerTypeSeparator(String FQN) { |
There was a problem hiding this comment.
Name FQN does not comply with Java conventions. Our xxxx-checkstyle doesn't detect this?
There was a problem hiding this comment.
Apparently not... I'll open an issue to fix/simplify the checkstyle!
monperrus
reviewed
Dec 16, 2016
| } | ||
|
|
||
| } | ||
| printer.writeln().writeTabs(); | ||
| } | ||
| } | ||
|
|
||
| private String removeInnerTypeSeparator(String FQN) { | ||
| return FQN.replace('$', '.'); |
There was a problem hiding this comment.
we have a TYPE_SEPARATOR representing $ somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues have been detected using spoon on open source projects (see https://ci.inria.fr/sos/job/EveryNightRegressionTesting/516/) du to failing static import on inner classes or enum.
Fix the detected errors by changing the way fully qualified name are printed in imports for inner classes (for now a $ was printed before the inner class name) and by detecting in the MinimalImportScanner if the simpleName of the currentRef is creating a collision: in that case, we should not import the element as it could create bug by autoreference.