-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typed parameters in access path #1007
fix typed parameters in access path #1007
Conversation
@@ -324,6 +324,9 @@ public TypeFactory() { | |||
} | |||
|
|||
ref.setSimpleName(type.getSimpleName()); | |||
for (CtTypeParameter typeParam : type.getFormalCtTypeParameters()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this change required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already found, that this change is wrong. I will rollback it and do it different.
4a92670
to
858fda0
Compare
This implementation is still not 100% correct, but
The remaining problem is how to correctly map actual type arguments. See the comment in |
it looks good to me, thanks. @tdurieux OK for you?
this is fine, in general |
@monperrus it is good for me |
fixes #1000