perf: Don't clone method body when adapting it for isOverriding (#4862)

src/main/java/spoon/support/adaption/TypeAdaptor.java

@@ -9,6 +9,7 @@
 
 import spoon.SpoonException;
 import spoon.processing.FactoryAccessor;
+import spoon.reflect.code.CtBlock;
 import spoon.reflect.declaration.CtConstructor;
 import spoon.reflect.declaration.CtElement;
 import spoon.reflect.declaration.CtExecutable;
@@ -403,8 +404,12 @@ public boolean isOverriding(CtMethod<?> subMethod, CtMethod<?> superMethod) {
 			return false;
 		}
 
+		// We don't need to clone the body here, so leave it out
+		CtBlock<?> superBody = superMethod.getBody();
+		superMethod.setBody(null);
 		CtMethod<?> adapted = new TypeAdaptor(subMethod.getDeclaringType())
 			.adaptMethod(superMethod);
+		superMethod.setBody(superBody);
 
 		for (int i = 0; i < subMethod.getParameters().size(); i++) {
 			CtParameter<?> subParam = subMethod.getParameters().get(i);

src/test/java/spoon/test/prettyprinter/TestSniperPrinter.java

@@ -45,6 +45,7 @@
 import spoon.reflect.reference.CtReference;
 import spoon.reflect.reference.CtTypeReference;
 import spoon.reflect.visitor.filter.TypeFilter;
+import spoon.support.adaption.TypeAdaptor;
 import spoon.support.modelobs.ChangeCollector;
 import spoon.support.modelobs.SourceFragmentCreator;
 import spoon.support.sniper.SniperJavaPrettyPrinter;
@@ -837,6 +838,25 @@ void testSniperAddsSpaceAfterFinal() {
 		testSniper("sniperPrinter.SpaceAfterFinal", modifyField, assertContainsSpaceAfterFinal);
 	}
 
+	@Test
+	void typeAdaptionBodyResetDoesNotBreakSniper() {
+		// contract: Resetting the body in the type adaption does not impact the sniper printer.
+		testSniper(
+			"sniperPrinter.Overriding",
+			type -> {
+				CtType<?> top = type.getNestedType("Super");
+				CtType<?> bottom = type.getNestedType("Sub");
+
+				CtMethod<?> topFoo = top.getMethodsByName("foo").get(0);
+				CtMethod<?> bottomFoo = bottom.getMethodsByName("foo").get(0);
+
+				assertTrue(new TypeAdaptor(bottom).isOverriding(bottomFoo, topFoo));
+			},
+			// Did not reformat body
+			(type, result) -> assertThat(result, containsString("System. out. println(1+2\n"))
+		);
+	}
+
 	@Nested
 	class ResourcePrintingInTryWithResourceStatement{
 		private CtTryWithResource getTryWithResource(CtType<?> type) {

src/test/resources/sniperPrinter/Overriding.java

@@ -0,0 +1,16 @@
+package sniperPrinter;
+
+public class Overriding {
+	public static class Super {
+		void foo() {
+			System. out. println(1+2
+			);
+		}
+	}
+
+	public static class Sub extends Super {
+		@Override
+		void foo() {
+		}
+	}
+}