Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Make cross-validation figures less inexact #765

Merged
merged 3 commits into from
May 17, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
FIX Make cross-validation figures less inexact
ArturoAmorQ committed Feb 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 900c6f706848993ad834f1cdfa8a12e287815550
Binary file modified figures/cross_validation_train_test_diagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified figures/nested_cross_validation_diagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 13 additions & 6 deletions figures/plot_parameter_tuning_cv.py
Original file line number Diff line number Diff line change
@@ -58,8 +58,12 @@ def plot_cv_indices(cv, X, y, ax, lw=50):
Patch(color=cmap_cv(0.5)),
Patch(color=cmap_cv(0.02)),
],
["Testing samples", "Training samples", "Validation samples"],
loc=(1.02, 0.7),
[
"Testing samples\n(reserved for\nfinal evaluation)",
"Training samples",
"Validation samples",
],
loc=(1.02, 0.5),
)
return ax

@@ -82,7 +86,6 @@ def plot_cv_nested_indices(cv_inner, cv_outer, X, y, ax, lw=50):

# Generate the training/testing visualizations for each CV split
for ii, (train_outer, test_outer) in enumerate(splits_outer):

splits_inner = list(cv_inner.split(train_outer))
n_splits_inner = len(splits_inner)

@@ -116,7 +119,7 @@ def plot_cv_nested_indices(cv_inner, cv_outer, X, y, ax, lw=50):
)
yticklabels = list(range(n_splits_outer))
ax.set(
yticks=n_splits_inner*np.arange(n_splits_outer) + 0.5,
yticks=n_splits_inner * np.arange(n_splits_outer) + 0.5,
yticklabels=yticklabels,
xlabel="Sample index",
ylabel="CV outer iteration",
@@ -129,8 +132,12 @@ def plot_cv_nested_indices(cv_inner, cv_outer, X, y, ax, lw=50):
Patch(color=cmap_cv(0.5)),
Patch(color=cmap_cv(0.02)),
],
["Testing samples", "Training samples", "Validation samples"],
loc=(1.06, .93),
[
"Testing samples\n(reserved for\nouter evaluation)",
"Training samples",
"Validation samples",
],
loc=(1.06, 0.85),
)
return ax