Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Emphasize discussion on multi-class classification in tree notebook #730
ENH Emphasize discussion on multi-class classification in tree notebook #730
Changes from 6 commits
12c3f33
8c987c6
7a495b5
f09d4ff
6df0565
307e84c
3d5e638
409117c
3c259f0
d6cacb3
68e54b6
5f6b570
dcd268c
6e148c2
7a21394
6674334
1db628b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogrisel does this paragraph make sense to you when using a diverging colormap?
Or can you please elaborate on how the 0.5 probability cannot be interpreted under this one-vs-rest logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed this paragraph needs to be updated with the new colors (e.g. bright yellow vs dark purple). What I mean is that the chance level for a one vs rest binary classification problem that comes from a multi-class classification problem is almost never at 0.5. So using a colormap with a neutral white at 0.5 might give a false impression.
When we do one-vs-rest, we do not threshold the value of predict_proba at 0.5 to get the hard class predictions but instead concatenate of the 3 one-vs-rest predict_proba vectors into a 2D array and take the argmax across the classes dimension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to keep the
colorbar
at the bottom of the plot in this case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so.