-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework ordering of linear models module #701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Aug 31, 2023
Co-authored-by: Olivier Grisel <[email protected]>
ArturoAmorQ
force-pushed
the
lectures_ordering
branch
from
August 31, 2023 14:51
febf376
to
513d696
Compare
Merged main to see the render with the synchronized quizzes from #708. |
ogrisel
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you @ArturoAmorQ. @glemaitre and I will now work on some follow-up PRs for feature engineering for linear classification and regularization for linear classification. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
Co-authored-by: ArturoAmorQ <[email protected]> Co-authored-by: Olivier Grisel <[email protected]> cbfedd1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #697. Fixes #641.
This PR addresses al the point in #697 except for the point:
This will be addressed in a different PR as I would like to fit the narrative to the new placing of this notebook.
Furthermore, we can consider moving Q2 from M4.05
out of the regularization lesson and into the Quiz M4.02, i.e. in the lesson on intuitions.