Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ordering of linear models module #701

Merged
merged 19 commits into from
Sep 1, 2023

Conversation

ArturoAmorQ
Copy link
Collaborator

@ArturoAmorQ ArturoAmorQ commented Jun 26, 2023

Fixes #697. Fixes #641.

This PR addresses al the point in #697 except for the point:

rename "Beyond linear separation in classification"

This will be addressed in a different PR as I would like to fit the narrative to the new placing of this notebook.

Furthermore, we can consider moving Q2 from M4.05

The decision boundaries of a logistic regression:
a) uses only one of the input features
b) uses a combination of the input features
c) separates a single class

out of the regularization lesson and into the Quiz M4.02, i.e. in the lesson on intuitions.

@ArturoAmorQ
Copy link
Collaborator Author

Merged main to see the render with the synchronized quizzes from #708.

Copy link
Collaborator

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel ogrisel merged commit cbfedd1 into INRIA:main Sep 1, 2023
@ogrisel
Copy link
Collaborator

ogrisel commented Sep 1, 2023

Thank you @ArturoAmorQ. @glemaitre and I will now work on some follow-up PRs for feature engineering for linear classification and regularization for linear classification.

github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
Co-authored-by: ArturoAmorQ <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]> cbfedd1
@ArturoAmorQ ArturoAmorQ deleted the lectures_ordering branch September 7, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants