-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KWave adapter rotation bug fix #270
Conversation
Currently manual test |
|
There are still some rot90 left in simpa, mostly in the plotting functions and some tests (also in KWaveAcousticForwardConvenienceFunction, which is one reason why the output looks so strange). We should probably replace them too :D |
You were right, the rot90 error was also a problem in the |
I switched
rot90
totranspose
transformation and deleted the reverse ordering of sensor elements in time series data.So far not test have been run. It might make sense to implement additional tests for avoiding such bugs.
Please check the following before creating the pull request (PR):
List any specific code review questions
List any special testing requirements
Please also test 3D case, this hasn't been done so far.
Additional context (e.g. papers, documentation, blog posts, ...)
Provide issue / feature request fixed by this PR
Fixes #264