Skip to content

Commit

Permalink
Merge pull request #24 from ILW8/disable-update-checker
Browse files Browse the repository at this point in the history
disable update checker
  • Loading branch information
ILW8 authored Apr 11, 2024
2 parents 48bc5e8 + 985134f commit 449b79e
Showing 1 changed file with 1 addition and 97 deletions.
98 changes: 1 addition & 97 deletions osu.Game/Updater/SimpleUpdateManager.cs
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
// Copyright (c) ppy Pty Ltd <[email protected]>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using System;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using System.Runtime.InteropServices;
using System.Threading.Tasks;
using osu.Framework;
using osu.Framework.Allocation;
using osu.Framework.Graphics.Sprites;
using osu.Framework.Platform;
using osu.Game.Online.API;
using osu.Game.Overlays.Notifications;

namespace osu.Game.Updater
{
Expand All @@ -21,96 +11,10 @@ namespace osu.Game.Updater
/// </summary>
public partial class SimpleUpdateManager : UpdateManager
{
private string version = null!;

[Resolved]
private GameHost host { get; set; } = null!;

[BackgroundDependencyLoader]
private void load(OsuGameBase game)
{
version = game.Version;
}

protected override async Task<bool> PerformUpdateCheck()
{
try
{
var releases = new OsuJsonWebRequest<GitHubRelease>("https://api.github.com/repos/ppy/osu/releases/latest");

await releases.PerformAsync().ConfigureAwait(false);

var latest = releases.ResponseObject;

// avoid any discrepancies due to build suffixes for now.
// eventually we will want to support release streams and consider these.
version = version.Split('-').First();
string latestTagName = latest.TagName.Split('-').First();

if (latestTagName != version && tryGetBestUrl(latest, out string? url))
{
Notifications.Post(new SimpleNotification
{
Text = $"A newer release of osu! has been found ({version}{latestTagName}).\n\n"
+ "Click here to download the new version, which can be installed over the top of your existing installation",
Icon = FontAwesome.Solid.Download,
Activated = () =>
{
host.OpenUrlExternally(url);
return true;
}
});

return true;
}
}
catch
{
// we shouldn't crash on a web failure. or any failure for the matter.
return true;
}

await Task.Delay(10).ConfigureAwait(false);
return false;
}

private bool tryGetBestUrl(GitHubRelease release, [NotNullWhen(true)] out string? url)
{
url = null;
GitHubAsset? bestAsset = null;

switch (RuntimeInfo.OS)
{
case RuntimeInfo.Platform.Windows:
bestAsset = release.Assets?.Find(f => f.Name.EndsWith(".exe", StringComparison.Ordinal));
break;

case RuntimeInfo.Platform.macOS:
string arch = RuntimeInformation.OSArchitecture == Architecture.Arm64 ? "Apple.Silicon" : "Intel";
bestAsset = release.Assets?.Find(f => f.Name.EndsWith($".app.{arch}.zip", StringComparison.Ordinal));
break;

case RuntimeInfo.Platform.Linux:
bestAsset = release.Assets?.Find(f => f.Name.EndsWith(".AppImage", StringComparison.Ordinal));
break;

case RuntimeInfo.Platform.iOS:
if (release.Assets?.Exists(f => f.Name.EndsWith(".ipa", StringComparison.Ordinal)) == true)
// iOS releases are available via testflight. this link seems to work well enough for now.
// see https://stackoverflow.com/a/32960501
url = "itms-beta://beta.itunes.apple.com/v1/app/1447765923";

break;

case RuntimeInfo.Platform.Android:
if (release.Assets?.Exists(f => f.Name.EndsWith(".apk", StringComparison.Ordinal)) == true)
// on our testing device using the .apk URL causes the download to magically disappear.
url = release.HtmlUrl;

break;
}

url ??= bestAsset?.BrowserDownloadUrl;
return url != null;
}
}
}

0 comments on commit 449b79e

Please sign in to comment.