Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with generic constructors when consumed from .NET 6 #17

Closed
IFYates opened this issue Nov 16, 2021 · 0 comments · Fixed by #18
Closed

Issue with generic constructors when consumed from .NET 6 #17

IFYates opened this issue Nov 16, 2021 · 0 comments · Fixed by #18
Assignees
@IFYates
Labels
bug
Milestone
v1.6.7

Comments

@IFYates
Copy link
Owner

IFYates commented Nov 16, 2021

Describe the bug
Using Shimterface via .NET 6 causes failures with the "generic constructor" usage.

Reproducible Example
Change Shimterface.Standard.Tests to dotnet6.0 and run them.
The 3 generic constructor tests fail.

Expected behavior
All tests pass.

Screenshots / Outputs

Test method Shimterface.Tests.GenericConstructorTests.Can_shim_to_constructor_with_multiple_args threw exception:
System.InvalidProgramException: Common Language Runtime detected an invalid program.

Environment (please complete the following information):

  • Version: 1.6.6
  • Platform: Library is netstandard2.1 but tests are dotnet6.0

Additional context
Changing library to dotnet6.0 does not solve the problem.

Seems to be a regression of #14
@IFYates IFYates self-assigned this Nov 16, 2021
@IFYates IFYates added the bug label Nov 16, 2021
@IFYates IFYates added this to the v1.6.7 milestone Nov 16, 2021
IFYates pushed a commit that referenced this issue Nov 16, 2021
Fixed IL on generic constructors for .NET 6
86df6f7 
Tests run for .NET Core 3.1, 5.0, 6.0
#17
@IFYates IFYates linked a pull request Nov 16, 2021 that will close this issue
Issue/17 #18
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IFYates IFYates

Labels
bug
Projects
None yet
Milestone
v1.6.7
Development

Successfully merging a pull request may close this issue.

Issue/17 IFYates/IFY.Shimr
1 participant
@IFYates