improve the usability of some editors #1206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderpann
force-pushed
the
bugfix/code_completion_menus
branch
from
3d254f4 to
36a688d
Compare
HeikoBecker
requested changes
Feb 4, 2025
There was a problem hiding this comment.
We have already discussed tye type system question in private messages.
Here are some findings on the editors:
- This editor diff looks strange. Might be worth double-checking:
- Potential typo:
execution _c_odevsexecution _m_ode
- I did not see code influencing this part, but we might want to fix this editor bug as well:
alexanderpann
force-pushed
the
bugfix/code_completion_menus
branch
from
36a688d to
d4d86f8
Compare
I noticed it as well but it is correct.
The last issue is unrelated to my changes. I created a ticket for it: #1210 |
HeikoBecker
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Thanks for addressing my nitpicks and for improving the editors!
Please wait for the review of @arimer before merging this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to improve the usability of editors. All aliases cells should support code completion e.g. the word "enum" in an enum declaration and all keywords should have the right color. This must be done for all editors where there is more then one editor cell. For single cells the code completion menu works by default.
In addition, I fixed the issue with string types vs string types with constraints which broken model checking in a few editors.