-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mahoyo voice fixes #6
Open
FallenStar08
wants to merge
22
commits into
IDerr:master
Choose a base branch
from
FallenStar08:mahoyo-voice-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superbe! J'essaie de review ça auj ou demain! |
J'ai ete trop optimiste, ca sera ce weekend... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonjour, voilà ma PR qui constate quelques (beaucoup) de problèmes avec le patch des voix éliminés !
Viennent ensuite les changements plus spécifiques, dans l'ordre et, si je n'ai rien oublié normalement (les changements en gras doivent probablement aussi être effectués sur le patch de base, car ils ne sont pas liés au patch voix) :
J'ai probablement omis quelques petits changements, comme des lignes audio qui jouaient au milieu du texte et non au début, mais cela devrait être visible dans les commits.
Voilà, j'ai joué entièrement avec la grosse modification et j'ai également vérifié les remises d'ordre des lignes audio après coup ; aucun problème particulier n'a été trouvé !
Désolé pour les commits nommées à la va-vite...
Il est fort probable qu'un petit problème ou deux subsistent, mais je pense avoir capturé l'essentiel !