add PCB design files from PCB design branch #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Too many files to review :-) It's good to have this info on the repo, but it is unclear to me if ok to "redistribute" those datasheets. |
|
What I'll do is remove the datasheets and just add a readme with links to them, all of them are publicly available, will also remove the kicad backup files, will switch this a draft review |
|
@edumeneses removed duplicated files, datasheets are linked in the schematics, once again ready for review |
|
Great work! IMO, it is ready to merge. If you think it is needed, we can add a README file to this folder with a one-sentence explanation and relevant links (if you think some datasheet is really important to reference). But this can definitely be done later. |
edumeneses
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PCB design files, no changes to firmware