-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix set_parameter_path
in Helmholtz Property Package
#1530
base: main
Are you sure you want to change the base?
Conversation
@bertkdowns Could you please format your PR with Black? I'd like to see if it breaks the CI. |
done, and the pytest tests passed on my machine, except for the ones that required the petsc solver as I didn't have it installed |
Looks like tests are passing, random Keras/multithreading errors nonwithstanding. @eslickj , if you get a chance, could you take a look to see if this breaks anything? At any rate, we should probably wait until after the 2.7 release to merge this. |
@lbianchi-lbl , I think you were going to take a look at this (when you get back)? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
+ Coverage 76.99% 77.02% +0.02%
==========================================
Files 385 387 +2
Lines 62288 62532 +244
Branches 10216 10241 +25
==========================================
+ Hits 47957 48163 +206
- Misses 11911 11936 +25
- Partials 2420 2433 +13 ☔ View full report in Codecov by Sentry. |
As far as I can tell it looks good. |
Fixes
Fix the set_parameter_path() function in helmholtz.
update
helmholtz_functions.py
andhelmholtz_state.py
to use the latest cfg variable rather than storing a copySummary/Motivation:
the set_parameter_path function does not properly update the helmholtz parameter file path, because it sets
idaes.properties.helmholtz.parameter_file_path
rather thanidaes.cfg.properties.parameter_file_path
(note .cfg).Also,
helmholtz_functions.py
makes a copy of the cfg variable into _data_dir, which also is not updated with set_parameter_path.This involves needing to do some hacky workarounds to specify a different directory to load helmholtz data from (e.g see my register_compounds function.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: