Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid Integration] Allow a generator to be "re-typed" in grid integration #1054

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

bknueven
Copy link
Contributor

Fixes N/A

Summary/Motivation:

Currently, changing the generator_type for a unit can have unpredictable results. This PR would switch the coordinator to use a few new callbacks in Prescient to make this more predictable. Waiting on grid-parity-exchange/Prescient#162 and subsequent release.

Changes proposed in this PR:

  • Update static parameters with new Prescient callbacks
  • Fake a module plugin type for Prescient.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bknueven
Copy link
Contributor Author

Not urgent; gmlc-dispatches/dispatches#169 contains a work-around which can be deployed in Dispatches for now.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 70.26% // Head: 70.26% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e95ca40) compared to base (06b6571).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   70.26%   70.26%   -0.01%     
==========================================
  Files         405      405              
  Lines       66247    66245       -2     
  Branches    12318    12315       -3     
==========================================
- Hits        46551    46544       -7     
- Misses      17324    17328       +4     
- Partials     2372     2373       +1     
Impacted Files Coverage Δ
idaes/apps/grid_integration/coordinator.py 96.19% <88.23%> (-0.98%) ⬇️
idaes/ver.py 61.53% <0.00%> (-4.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrewlee94 andrewlee94 changed the title Allow a generator to be "re-typed" in grid integration [Grid Integration] Allow a generator to be "re-typed" in grid integration Dec 16, 2022
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Dec 22, 2022
@ksbeattie ksbeattie marked this pull request as ready for review February 6, 2023 18:21
@bknueven bknueven requested a review from Xinhe-Chen February 6, 2023 18:22
@ksbeattie ksbeattie added Priority:High High Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels Feb 9, 2023
@Xinhe-Chen
Copy link
Contributor

@adowling2 This is the PR we need to review in order to complete the IDAES march milestone.

@ksbeattie ksbeattie merged commit 38df145 into IDAES:main Feb 13, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (06b6571) to head (e95ca40).
Report is 225 commits behind head on main.

Files with missing lines Patch % Lines
idaes/apps/grid_integration/coordinator.py 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   70.26%   70.26%   -0.01%     
==========================================
  Files         405      405              
  Lines       66247    66245       -2     
  Branches    12318    12315       -3     
==========================================
- Hits        46551    46544       -7     
- Misses      17324    17328       +4     
- Partials     2372     2373       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DISPATCHES Priority:High High Priority Issue or PR
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants