-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Grid Integration] Allow a generator to be "re-typed" in grid integration #1054
Conversation
Not urgent; gmlc-dispatches/dispatches#169 contains a work-around which can be deployed in Dispatches for now. |
Codecov ReportBase: 70.26% // Head: 70.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
- Coverage 70.26% 70.26% -0.01%
==========================================
Files 405 405
Lines 66247 66245 -2
Branches 12318 12315 -3
==========================================
- Hits 46551 46544 -7
- Misses 17324 17328 +4
- Partials 2372 2373 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@adowling2 This is the PR we need to review in order to complete the IDAES march milestone. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
- Coverage 70.26% 70.26% -0.01%
==========================================
Files 405 405
Lines 66247 66245 -2
Branches 12318 12315 -3
==========================================
- Hits 46551 46544 -7
- Misses 17324 17328 +4
- Partials 2372 2373 +1 ☔ View full report in Codecov by Sentry. |
Fixes N/A
Summary/Motivation:
Currently, changing the
generator_type
for a unit can have unpredictable results. This PR would switch the coordinator to use a few new callbacks in Prescient to make this more predictable. Waiting on grid-parity-exchange/Prescient#162 and subsequent release.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: