Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIU-385: Add support for SubGraphs in translator #262

Merged
merged 1 commit into from
Jun 6, 2024
Merged

LIU-385: Add support for SubGraphs in translator #262

merged 1 commit into from
Jun 6, 2024

Conversation

myxie
Copy link
Collaborator

@myxie myxie commented May 31, 2024

This supports SubGraphs with no InputApps, which functionally ignores the entire SubGraph construct.

Logical Graph Translated Graph
image image

This does not address the functionality of sub-graphs with input apps, nor does it make any attempt to address the translation of those graphs; this may lead to undefined behaviour if a sub-graph with input apps is submitted for translation.

Summary by Sourcery

This pull request adds support for SubGraphs in the translator, specifically handling SubGraphs with no InputApps. It introduces a new property to identify SubGraph nodes and updates relevant functions to process these constructs.

  • New Features:
    • Added support for SubGraphs in the translator, allowing SubGraphs with no InputApps to be processed.
  • Enhancements:
    • Introduced a new property is_subgraph in lg_node.py to identify SubGraph nodes.
    • Updated convert_construct function in dm_utils.py to handle SubGraph constructs.

This supports SubGraphs with no InputApps, which functionally ignores the entire SubGraph construct.
@myxie myxie marked this pull request as ready for review June 6, 2024 01:59
Copy link
Contributor

sourcery-ai bot commented Jun 6, 2024

Reviewer's Guide by Sourcery

This pull request adds support for SubGraphs in the translator, specifically handling SubGraphs with no InputApps. The changes ensure that SubGraphs are recognized and processed correctly, while ignoring the entire SubGraph construct if it has no InputApps. This update does not address the functionality of SubGraphs with InputApps, which may lead to undefined behavior if such SubGraphs are submitted for translation.

File-Level Changes

Files Changes
daliuge-translator/dlg/dropmake/lg.py
daliuge-translator/dlg/dropmake/dm_utils.py
daliuge-translator/dlg/dropmake/lg_node.py
daliuge-translator/dlg/dropmake/definition_classes.py
Added support for SubGraphs in the translator, including recognition and processing of SubGraphs with no InputApps.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @myxie - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 6 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@coveralls
Copy link

Coverage Status

coverage: 79.626% (-0.03%) from 79.653%
when pulling caa24e3 on LIU-385
into 22fb53d on master.

@myxie myxie merged commit ae0743d into master Jun 6, 2024
21 checks passed
awicenec pushed a commit that referenced this pull request Oct 10, 2024
LIU-385: Add support for SubGraphs in translator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants