-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIU-385: Add support for SubGraphs in translator #262
Conversation
This supports SubGraphs with no InputApps, which functionally ignores the entire SubGraph construct.
Reviewer's Guide by SourceryThis pull request adds support for SubGraphs in the translator, specifically handling SubGraphs with no InputApps. The changes ensure that SubGraphs are recognized and processed correctly, while ignoring the entire SubGraph construct if it has no InputApps. This update does not address the functionality of SubGraphs with InputApps, which may lead to undefined behavior if such SubGraphs are submitted for translation. File-Level Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @myxie - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 6 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
LIU-385: Add support for SubGraphs in translator
This supports SubGraphs with no InputApps, which functionally ignores the entire SubGraph construct.
This does not address the functionality of sub-graphs with input apps, nor does it make any attempt to address the translation of those graphs; this may lead to undefined behaviour if a sub-graph with input apps is submitted for translation.
Summary by Sourcery
This pull request adds support for SubGraphs in the translator, specifically handling SubGraphs with no InputApps. It introduces a new property to identify SubGraph nodes and updates relevant functions to process these constructs.
is_subgraph
inlg_node.py
to identify SubGraph nodes.convert_construct
function indm_utils.py
to handle SubGraph constructs.