Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manager host to list of nodes when deploy method is Server #256

Merged
merged 1 commit into from
May 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion daliuge-translator/dlg/dropmake/web/translator_rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ def gen_pg(
host=mhost, port=mport, url_prefix=mprefix, timeout=30
)
# 1. get a list of nodes
node_list = mgr_client.nodes()
node_list = [f"{mhost}:{mport}"] + mgr_client.nodes()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awicenec Are you happy with this approach to the fix? I recall you saying in-person you'd made changes to the API instead, but that may have been orthogonal to this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are perfect, thanks.

logger.debug("Calling mapping to nodes: %s", node_list)
# 2. mapping PGTP to resources (node list)
pg_spec = pgtp.to_pg_spec(node_list, ret_str=False)
Expand Down
Loading