feature: implement CreateNlpBatchesFromIndexTask and BatchNlpTask
#1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemDoum
force-pushed
the
feature/batch-nlp-task
branch
3 times, most recently
from
5520b8c to
06941ae
Compare
ClemDoum
force-pushed
the
feature/batch-nlp-task
branch
2 times, most recently
from
70042eb to
820b524
Compare
ClemDoum
changed the title
BatchEnqueueFromIndexTask.javaCreateNlpBatchesFromIndexTask and BatchNlpTask
This was referenced Nov 12, 2024
ClemDoum
force-pushed
the
feature/batch-nlp-task
branch
2 times, most recently
from
7c365c8 to
ec856be
Compare
ClemDoum
force-pushed
the
feature/batch-nlp-task
branch
from
d85f65e to
4c3a08f
Compare
ClemDoum
force-pushed
the
feature/batch-nlp-task
branch
from
9bcd838 to
688bced
Compare
ClemDoum
force-pushed
the
feature/batch-nlp-task
branch
from
688bced to
e7f5239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
PR description
Implemenent batch processing for NER, this change is made in the context of #1452, as batch processing is necessary for Spacy.
Notes
In this PR we made the choice not to implement
PipelineTaskbut in contrast fully rely on the task bus to distribute the batches across workersChanges
datashare-apiAdded
Searcher sort(String field, SortOrder order)method toIndexer.Searcherto sort search results and be able to return documents grouped by language (to avoid model reload)datashare-appAdded
CreateNlpBatchesFromIndexTasktask which scan the index for document sorted by language. Documents are then added by batch to theBatchNlpTaskqueue, where workers will process document to perform NER by batchBatchNlpTaskwhich consumes document by batches, fetches them from the index and performs the NLP task (NER only)