-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Chain Burn-in Calculation in Thermodynamic Integration #1361
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1361 +/- ##
===========================================
+ Coverage 84.43% 84.46% +0.02%
===========================================
Files 157 157
Lines 12881 12899 +18
===========================================
+ Hits 10876 10895 +19
+ Misses 2005 2004 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, adding a option whether to take the maximum of the burn-ins over all chains or each chain individually, would be great. But for the moment fine as it is. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the warnings and option implementation.
Several weeks ago, I introduced a function to calculate the log evidence from a parallel tempering run using thermodynamic integration. Initially, only the first chain was assessed for convergence and the burn-in was determined. Now, I've enhanced the process by computing the burn-in individually for each chain, enhancing the validity and accuracy of the approximation.