Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix links, typos, grammer, punctuation in doc/example/amici.ipynb #1248

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 15, 2023

No description provided.

@dweindl dweindl requested a review from a team as a code owner December 15, 2023 10:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 384 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (ca0c2ad) 82.53%.
Report is 475 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 69.77% 68 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 82.62% 53 Missing ⚠️
pypesto/ensemble/util.py 65.13% 38 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/history/base.py 88.57% 24 Missing ⚠️
pypesto/hierarchical/petab.py 84.76% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 88.51% 17 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/problem.py 89.05% 15 Missing ⚠️
... and 15 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1248      +/-   ##
===========================================
- Coverage    88.16%   82.53%   -5.64%     
===========================================
  Files           79      148      +69     
  Lines         5257    12067    +6810     
===========================================
+ Hits          4635     9959    +5324     
- Misses         622     2108    +1486     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl requested a review from FFroehlich as a code owner December 15, 2023 11:18
@dweindl dweindl self-assigned this Dec 15, 2023
@dweindl dweindl merged commit 4fdc50f into ICB-DCM:develop Dec 17, 2023
15 of 17 checks passed
This was referenced Jan 30, 2024
@dweindl dweindl deleted the doc_nb branch November 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants