Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: reduce test failure frequency #1240

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Select: reduce test failure frequency #1240

merged 1 commit into from
Dec 6, 2023

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Dec 6, 2023

closes #1183

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 396 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (32961d1) 84.19%.
Report is 467 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 69.36% 68 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 83.68% 47 Missing ⚠️
pypesto/ensemble/util.py 65.13% 38 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/history/base.py 88.57% 24 Missing ⚠️
pypesto/hierarchical/petab.py 84.56% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 89.04% 16 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/optimal_scaling/calculator.py 75.86% 14 Missing ⚠️
... and 19 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1240      +/-   ##
===========================================
- Coverage    88.16%   84.19%   -3.98%     
===========================================
  Files           79      148      +69     
  Lines         5257    11875    +6618     
===========================================
+ Hits          4635     9998    +5363     
- Misses         622     1877    +1255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@dilpath dilpath merged commit cba1609 into develop Dec 6, 2023
17 checks passed
@dilpath dilpath deleted the fix_1183 branch December 6, 2023 16:15
@PaulJonasJost PaulJonasJost linked an issue Dec 7, 2023 that may be closed by this pull request
This was referenced Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test/select/test_select.py::test_problem_select - AssertionError
3 participants