Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia caching more efficient. #1231

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Julia caching more efficient. #1231

merged 10 commits into from
Dec 4, 2023

Conversation

PaulJonasJost
Copy link
Collaborator

Make Julia caching more efficient through Julia-actions

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 398 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (ae0b67e) 84.07%.
Report is 458 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 69.36% 68 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 83.68% 47 Missing ⚠️
pypesto/ensemble/util.py 65.13% 38 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/history/base.py 88.57% 24 Missing ⚠️
pypesto/hierarchical/petab.py 84.56% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 89.04% 16 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/optimal_scaling/calculator.py 75.86% 14 Missing ⚠️
... and 19 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1231      +/-   ##
===========================================
- Coverage    88.16%   84.07%   -4.10%     
===========================================
  Files           79      148      +69     
  Lines         5257    11863    +6606     
===========================================
+ Hits          4635     9974    +5339     
- Misses         622     1889    +1267     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dweindl dweindl linked an issue Dec 1, 2023 that may be closed by this pull request
@dweindl
Copy link
Member

dweindl commented Dec 1, 2023

Note that actions/cache should come before install_deps.sh and julia-actions/cache should come before installing petab.jl deps.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PaulJonasJost PaulJonasJost marked this pull request as ready for review December 1, 2023 15:51
@PaulJonasJost PaulJonasJost requested a review from a team as a code owner December 1, 2023 15:51
@PaulJonasJost PaulJonasJost merged commit 8201375 into develop Dec 4, 2023
17 checks passed
@PaulJonasJost PaulJonasJost deleted the julia_caching branch December 4, 2023 14:03
This was referenced Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequent Julia test timeout
4 participants