-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docstring on history module #1230
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1230 +/- ##
===========================================
- Coverage 88.16% 84.11% -4.06%
===========================================
Files 79 148 +69
Lines 5257 11863 +6606
===========================================
+ Hits 4635 9978 +5343
- Misses 622 1885 +1263 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -70,18 +70,18 @@ def update( | |||
|
|||
def finalize( | |||
self, | |||
message: str = None, | |||
exitflag: str = None, | |||
message: Union[str, None] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future use: this is equivalent to Optional[str]
. Slightly shorter. Fine to leave as is.
Co-authored-by: Daniel Weindl <[email protected]>
More in Line with the Sphinx docstring