Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pypesto.profile #1225

Merged
merged 11 commits into from
Nov 30, 2023
Merged

Cleanup pypesto.profile #1225

merged 11 commits into from
Nov 30, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 29, 2023

  • documentation
  • typehints
  • simplify

* documentation
* typehints
* simplify
@dweindl dweindl self-assigned this Nov 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 396 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (5697fec) 84.11%.
Report is 449 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 69.36% 68 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 83.68% 47 Missing ⚠️
pypesto/ensemble/util.py 65.13% 38 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/history/base.py 88.57% 24 Missing ⚠️
pypesto/hierarchical/petab.py 84.56% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 89.04% 16 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/optimal_scaling/calculator.py 75.86% 14 Missing ⚠️
... and 19 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1225      +/-   ##
===========================================
- Coverage    88.16%   84.11%   -4.06%     
===========================================
  Files           79      148      +69     
  Lines         5257    11856    +6599     
===========================================
+ Hits          4635     9973    +5338     
- Misses         622     1883    +1261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl requested a review from a team as a code owner November 30, 2023 10:31
pypesto/profile/profile_next_guess.py Show resolved Hide resolved
pypesto/profile/validation_intervals.py Outdated Show resolved Hide resolved
@PaulJonasJost
Copy link
Collaborator

thanks a lot for this 🙏

@dweindl dweindl merged commit 9fed090 into ICB-DCM:develop Nov 30, 2023
17 checks passed
@dweindl dweindl deleted the cleanup_profile branch November 30, 2023 12:33
This was referenced Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants